New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uib-dropdown attribute required? #27

Closed
bignall opened this Issue Oct 4, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@bignall
Contributor

bignall commented Oct 4, 2016

The docs say the uib-dropdown attribute is not required and I see in the demo that it is not used (although the uib-dropdown attribute is still generated instead of the dropdown attribute attribute it looks like it should be generating), however I tried and tried to get it working without the uib-dropdown attribute but I couldn't get any drop down that way. I finally decided to add the uib-dropdown attribute and magically it started working.

I couldn't track down why it wasn't working (perhaps there's some missing required library?) so I don't have a pull request to offer for this one.

@jshor

This comment has been minimized.

Show comment
Hide comment
@jshor

jshor Oct 5, 2016

Owner

I forgot what version of angular-bootstrap this change occurred on, but if I remember correctly, after that version the bootstrap dropdown became part of ui-bootstrap which necessitated the uib-dropdown attribute

Owner

jshor commented Oct 5, 2016

I forgot what version of angular-bootstrap this change occurred on, but if I remember correctly, after that version the bootstrap dropdown became part of ui-bootstrap which necessitated the uib-dropdown attribute

@bignall

This comment has been minimized.

Show comment
Hide comment
@bignall

bignall Oct 5, 2016

Contributor

Ahh. Thanks for the explanation. Maybe more info on that in the Readme and deprecating the old way so that uib-dropdown becomes the default eventually?

Contributor

bignall commented Oct 5, 2016

Ahh. Thanks for the explanation. Maybe more info on that in the Readme and deprecating the old way so that uib-dropdown becomes the default eventually?

jshor added a commit that referenced this issue Oct 13, 2016

@jshor

This comment has been minimized.

Show comment
Hide comment
@jshor

jshor Oct 13, 2016

Owner

Good catch, I've updated the docs

Owner

jshor commented Oct 13, 2016

Good catch, I've updated the docs

@jshor jshor closed this Oct 13, 2016

jshor added a commit that referenced this issue Oct 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment