New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
application/javascript should be replaced with text/javascript #110
Comments
Oops, looks like this belongs in the mime-db repo first and then update this repo to pull the mime-db with fix. Apologies |
Remember to release the dependency update here as semver-major as this will break compatibility unless consumers carefully update their code. For example, when Node.js is used as a web server using this package, the mime type is exposed to middleware and outside clients and may be relied upon in all sorts of ways. Example: https://github.com/bitovi/testee/blob/v0.10.2/lib/host/coverage.js#L20-L32 |
@broofa Exactly. That's why this higher level package pins the version of that lower level library, to ensure it won't accidentally update, as that constitutes a breaking and semver-major at this level. |
Yes, this pins so there are two decision points. The semver is tricky bc typically in both packages, the data is has not been considered in the semver, as the way in which data changes in fluid with standards and browsers and there can be a lot of changes. Usually only the javascript api of the module has been considered in whay type of semver bump it would be. |
I note that the application/javascript was deprecated two years ago now, and should be replaced by text/javascript.
For more info, see,
Happy to create a PR if this change would be accepted.
The text was updated successfully, but these errors were encountered: