Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported to JS #1

Closed
isaacs opened this issue Apr 24, 2012 · 4 comments
Closed

Ported to JS #1

isaacs opened this issue Apr 24, 2012 · 4 comments

Comments

@isaacs
Copy link
Contributor

isaacs commented Apr 24, 2012

This was the only fully complete content negotiation library I could find. However, it's in CoffeeScript, and not precompiled, and also uses underscore a bit unnecessarily, making it not optimal for my use.

So, I ported it to JS. The result is not so bad. There are some parts that could still be a bit more abstracted out for greater DRY-ness, but they're pretty minimal.

I know sometimes people convert libs back and forth out of trollish desires, but that's not my goal here at all. I really just wanted to use this library without having to load coffee-script at run time. I changed the name, and republished it as "negotiator.js" to differentiate it: https://github.com/isaacs/negotiator.js

If you are interested in merging the two, I will be happy to continue maintaining it. If not, then feel free to close this issue, and we can live side by side in peace :)

@federomero
Copy link
Contributor

I think merging the two is a good idea, would you like me to add you as a collaborator to this repo?

@isaacs
Copy link
Contributor Author

isaacs commented Apr 24, 2012

Sure, either that, or I can send you a pull req. Are you saying that you'd be ok with it being just a JavaScript thing, and lose the coffee-script dep?

@isaacs isaacs mentioned this issue Apr 24, 2012
@federomero
Copy link
Contributor

Yes, I don't mind it being just javascript.

@isaacs
Copy link
Contributor Author

isaacs commented Apr 24, 2012

Ok, awesome! I'll change the name back, then, and remove my renamed version from npm and githuib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants