Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding order wrong #10

Closed
tj opened this issue Sep 14, 2013 · 5 comments
Closed

encoding order wrong #10

tj opened this issue Sep 14, 2013 · 5 comments

Comments

@tj
Copy link

tj commented Sep 14, 2013

Accept-Encoding: gzip, deflate is giving me ['deflate', 'gzip'] with:

  get acceptedEncodings() {
    var n = new Negotiator(this.req);
    return n.preferredEncodings();
  },
@federomero
Copy link
Contributor

I'm not sure this is a bug since I couldn't find anywhere in the rfc that says that order of appearance of the encodings is relevant. Did you run into a situation where this is an issue?

@federomero
Copy link
Contributor

I think I'll probably change it anyways because it's a simple change.

@tj
Copy link
Author

tj commented Sep 14, 2013

yeah I'm not sure if it matters via RFC either but seems logical from a user perspective

@tj
Copy link
Author

tj commented Sep 14, 2013

no mention of it, just "If multiple content-codings are acceptable, then the acceptable content-coding with the highest non-zero qvalue is preferred." - so I guess it's left to interpretation

@federomero
Copy link
Contributor

I just fixed it on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants