Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Station name and ID returned attributes #1

Open
deepcoder opened this issue Jun 9, 2020 · 1 comment
Open

Station name and ID returned attributes #1

deepcoder opened this issue Jun 9, 2020 · 1 comment

Comments

@deepcoder
Copy link

I'm sure there has to be a better way to accomplish this than what I show below. Neither the original or your code seem to return the name and ID of the reporting station. Since you can have multiple or need different stations if water temperature not reported at your nearest station. Recording the source of the data may be useful:

    attr["station_name"] = self._station.metadata['name']
    attr["station_id"] = self._station.metadata['id']
@jshufro
Copy link
Owner

jshufro commented Jun 9, 2020

Seems like it would make a nice improvement. You can differentiate data returned by distinct stations already if you supply a name attribute in your configuration, but it would be nice to surface the values returned by the NOAA as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants