Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[switchbot_ros] use python setup to avoid relative import in switchbot_ros #278

Merged
merged 3 commits into from Sep 8, 2021
Merged

[switchbot_ros] use python setup to avoid relative import in switchbot_ros #278

merged 3 commits into from Sep 8, 2021

Conversation

knorth55
Copy link
Member

I use catkin_setup_python to make switchbot_ros as python package.
This PR avoids relative import in switchbot_ros_server.py, which may causes error in python3.

@knorth55 knorth55 requested a review from mqcmd196 August 11, 2021 05:15
mqcmd196
mqcmd196 approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@mqcmd196 mqcmd196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine! Thanks!

@k-okada k-okada merged commit 68e4595 into jsk-ros-pkg:master Sep 8, 2021
@knorth55 knorth55 deleted the switchbot-ros-python-setup branch September 8, 2021 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mqcmd196 mqcmd196 mqcmd196 approved these changes

Assignees
No one assigned
Labels
enhancement switchbot_ros
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knorth55 @mqcmd196 @k-okada