[dialogflow_task_executive] add speech_to_text_other topic name in speech_to_text_mux #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Does the usage mean the following?
- we select
/speech_to_text_othertopic in the/muxnode - the contents of /speech_to_text will be empty
- there will be no more input to dialogflow
If so, the name /speech_to_text_other seems inappropriate.
Should it be /speech_to_text_empty or /speech_to_text_disable?
|
|
|
OK, thank you for your explanation. |
708yamaguchi
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
/speech_to_text_othertopic inspeech_to_text_muxfordialogflow_task_executive.this is for an extension for new speech recognition node (such as
ros_speech_recognition),and this is also a placeholder to diable
dialogflow.cc. @MiyabiTane