Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dialogflow_task_executive] fix typo in dialogflow_client.py #445

Merged
merged 1 commit into from Mar 27, 2023
Merged

[dialogflow_task_executive] fix typo in dialogflow_client.py #445

merged 1 commit into from Mar 27, 2023

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Mar 25, 2023 •
edited

in python3, sys.version is str, so we cannot compare str and int.
this PR fix to use sys.version_info.major, which is int

[rosout][ERROR] 2023-03-25 23:23:33,705: '<=' not supported between instances of 'str' and 'int'

@knorth55 knorth55 requested a review from mqcmd196 March 25, 2023 14:50
@knorth55 knorth55 added the bug label Mar 25, 2023
This was referenced Mar 25, 2023
Open
Closed
@k-okada k-okada merged commit 435b936 into jsk-ros-pkg:master Mar 27, 2023
10 checks passed
@knorth55 knorth55 deleted the dialog-fix-python3 branch March 27, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mqcmd196 mqcmd196 Awaiting requested review from mqcmd196

Assignees
No one assigned
Labels
bug dialogflow_task_executive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@knorth55 @k-okada