Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rostwitter] use sub and not delete #446

Merged
merged 1 commit into from Mar 27, 2023
Merged

[rostwitter] use sub and not delete #446

merged 1 commit into from Mar 27, 2023

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Mar 25, 2023 •
edited

this PR change to use sub instead of self.sub.
with this chage, sub will always be removed when callback exits.
this prevents subscribing the topic forever.

@knorth55 knorth55 added bug and removed rostwitter labels Mar 25, 2023
This was referenced Mar 25, 2023
Closed
Open
@k-okada k-okada merged commit 325af3a into jsk-ros-pkg:master Mar 27, 2023
10 checks passed
@knorth55 knorth55 deleted the del-sub branch March 27, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug rostwitter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@knorth55 @k-okada