Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Waiting for upstream] use :add-neighbor-from-to in pddl-result-graph.l #92

Closed
wants to merge 1 commit into from

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Aug 27, 2021

waiting for upstream: euslisp/jskeus#605

we should use :add-neighbor-from-to instead of :add-neighbor.

This is because :add-neighbor adds arc, which is not suitable for pddl-graph.
pddl-graph inherits costed-graph, so all arcs should be costed-arc.
This PR changes to use :add-neighbor-from-to, which adds costed-arc (not arc) between from and to.

k-okada added a commit to k-okada/jsk_planning that referenced this pull request Nov 2, 2021
cannot run graph-solver for pddl-graph

see jsk-ros-pkg#92 for detail
@k-okada k-okada mentioned this pull request Nov 2, 2021
@k-okada
Copy link
Member

k-okada commented Nov 16, 2021

I think we do not need this if we merge #94. Please double check @Kanazawanaoaki

@knorth55 knorth55 closed this Nov 16, 2021
@knorth55
Copy link
Member Author

:add-arc-from-to solves this issue.

@knorth55 knorth55 deleted the add-neighbor-from-to branch November 16, 2021 07:08
k-okada added a commit that referenced this pull request Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants