Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test to check #92 #94

Merged
merged 2 commits into from Nov 19, 2021
Merged

add test to check #92 #94

merged 2 commits into from Nov 19, 2021

Conversation

k-okada
Copy link
Member

@k-okada k-okada commented Nov 2, 2021 •
edited

cannot run graph-solver for pddl-graph

see #92 for detail

use :add-arc-from-to instead of :add-neighbor, which is obsoleted methods

https://github.com/euslisp/jskeus/blob/89932980fe64eb0c0db6dbe6b79b61e2d3d17169/irteus/irtgraph.l#L379-L382

cc: @Kanazawanaoaki

@k-okada
add test to check jsk-ros-pkg#92
6b28fa9 
cannot run graph-solver for pddl-graph

see jsk-ros-pkg#92 for detail
@k-okada
Copy link
Member Author

k-okada commented Nov 16, 2021

@Kanazawanaoaki please add your comments on review tab

This was referenced Nov 16, 2021
Closed
Closed
Kanazawanaoaki
Kanazawanaoaki approved these changes Nov 19, 2021
View reviewed changes
Copy link

@Kanazawanaoaki Kanazawanaoaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine and I think it solves the costed-arc problem.
I didn't know that propertied-object which is higher class of costed-arc and arc could have a name in the first place.

@k-okada k-okada merged commit efbb394 into jsk-ros-pkg:master Nov 19, 2021
@k-okada k-okada deleted the fix_92 branch November 29, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kanazawanaoaki Kanazawanaoaki Kanazawanaoaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@k-okada @Kanazawanaoaki