add tms comment to :angle-vector-sequence #299
Conversation
|
In general, I'd like to use (almost) common documentation with other documentations as possible: |
pr2eus/robot-interface.l
Outdated
| @@ -401,7 +401,15 @@ | |||
| av) | |||
| (:angle-vector-sequence | |||
| (avs &optional (tms (list 3000)) (ctype controller-type) (start-time 0.1) &key (scale 1) (min-time 0.0) (end-coords-interpolation nil)) | |||
| "Send joind angle to robot, this method retuns immediately, so use :wait-interpolation to block until the motion stops." | |||
| "Send joind angle to robot, this method retuns immediately, so use :wait-interpolation to block until the motion stops. | |||
| - asv : list of joint angle vector [rad] | |||
There was a problem hiding this comment.
I see, so have to change
jsk_pr2eus/pr2eus/robot-interface.l
Line 350 in 035f676
pr2eus/robot-interface.l
Outdated
| - tms : list duration from previous angle-vector to next goal in [msec] | ||
| - ctype : controller method name | ||
| - start-time : time to start moving | ||
| - scale : if tm is not specified, it will use 1/scale of the fastest speed |
There was a problem hiding this comment.
tm should be for :angle-vector.
How about tms?
pr2eus/robot-interface.l
Outdated
| - ctype : controller method name | ||
| - start-time : time to start moving | ||
| - scale : if tm is not specified, it will use 1/scale of the fastest speed | ||
| - min-time : minimum time to for time to goal |
There was a problem hiding this comment.
Is this for :angle-vector?
How about :angle-vector-sequence?
And, minimum time to for time to goal -> minimum time to goal in english??
pr2eus/robot-interface.l
Outdated
| @@ -401,7 +401,15 @@ | |||
| av) | |||
| (:angle-vector-sequence | |||
| (avs &optional (tms (list 3000)) (ctype controller-type) (start-time 0.1) &key (scale 1) (min-time 0.0) (end-coords-interpolation nil)) | |||
| "Send joind angle to robot, this method retuns immediately, so use :wait-interpolation to block until the motion stops." | |||
| "Send joind angle to robot, this method retuns immediately, so use :wait-interpolation to block until the motion stops. | |||
There was a problem hiding this comment.
joind angle -> joint angles?
|
thank you for comment, this PR is to add comment to |
|
LGTM. |
c.f. jsk-ros-pkg/jsk_robot#791 (review)