Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pr2eus] add gain key in :stop-grasp #415

Merged
merged 2 commits into from Dec 16, 2019

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Nov 5, 2019

We need to change gain also for :stop-grasp.
This is because we introduce Gecko tape on PR2 finger tip.

@pazeshun
Copy link
Collaborator

pazeshun commented Nov 5, 2019

What happens when gain is default?

@YutoUchimi
Copy link
Contributor

PR2 tries to open his gripper, but cannot achieve for about 3~20 seconds (It seems that the latency depends on the time since last :start-grasp and probably on grasping gain...?).
I tested this PR with real robot and it works fine.

@k-okada
Copy link
Member

k-okada commented Nov 6, 2019 via email

@YutoUchimi
Copy link
Contributor

Yes, we introduced new fingertips with Gecko tape into PR1040 yesterday, and this is the first time to use it.

@knorth55
Copy link
Member Author

knorth55 commented Nov 6, 2019

Gecko tape is strongly attached if PR2 closes the gripper with some effort.
That's why we need to set more effort to open the gripper.

@knorth55 knorth55 changed the title add gain key in :stop-grasp [pr2eus] add gain key in :stop-grasp Nov 18, 2019
@knorth55
Copy link
Member Author

It is like a lottery to pass travis test.
I strongly want to merge #417 and make test work properly.

@knorth55
Copy link
Member Author

knorth55 commented Dec 5, 2019

@k-okada Travis test passed. Could you merge this PR?

@k-okada
Copy link
Member

k-okada commented Dec 14, 2019

@knorth55 what is 0.03 means and why you multiply by 2000 ?

@knorth55
Copy link
Member Author

@k-okada
I just follow line in :start-grasp. I have no idea why :gain is multiplied by 2000.
https://github.com/jsk-ros-pkg/jsk_pr2eus/blob/master/pr2eus/pr2-interface.l#L266-L267

I digged up commit history and found that this weird 2000 is added in 2010.
dfef9d8

@k-okada k-okada merged commit 6ca4441 into jsk-ros-pkg:master Dec 16, 2019
@knorth55 knorth55 deleted the add-gain-key branch December 16, 2019 08:26
@knorth55
Copy link
Member Author

@k-okada according to PR2 manual, max effort of PR2 gripper joint is 1000N. so probably, (* gain 1000) might be reasonable now.
was the max effort 2000 in 2010 and set lower limit now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants