Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pr2eus] Fix typo :cmd-vel-topi -> :cmd-vel-topic #480

Merged
merged 3 commits into from May 28, 2022
Merged

[pr2eus] Fix typo :cmd-vel-topi -> :cmd-vel-topic #480

merged 3 commits into from May 28, 2022

Conversation

nakane11
Copy link
Member

fix typo in robot-interface.l

iory
iory reviewed May 13, 2022
View reviewed changes
Copy link
Member

@iory iory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps some users are using cmd-vel-topi in their programs.
It's better to keep :cmd-vel-topi, add :cmd-vel-topic, and display a warning message if :cmd-vel-topi is specified.

@k-okada k-okada merged commit ba3567b into jsk-ros-pkg:master May 28, 2022
@nakane11 nakane11 deleted the fix-typo branch May 28, 2022 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iory iory iory approved these changes

@Affonso-Gui Affonso-Gui Affonso-Gui approved these changes

Assignees
No one assigned
Labels
PR/MergeOk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nakane11 @iory @Affonso-Gui @k-okada