Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fetch] Correct head orientation for look-at #771

Closed
wants to merge 1 commit into from

Conversation

Affonso-Gui
Copy link
Member

Rotates head end-coords such that z axis faces forward in order to fix look-at method glitch (always faces down).

@k-okada
Copy link
Member

k-okada commented Apr 27, 2017

please paste irtviewer image showing before and after head end coordinates, also code that reproduce your problem will help us (then I'll add test code to https://github.com/jsk-ros-pkg/jsk_robot/blob/master/jsk_fetch_robot/fetcheus/test/test-fetcheus.l)

@Affonso-Gui
Copy link
Member Author

The following images show fetch's head-end-coords and (orient-coords-to-axis (send *fetch* :rarm-end-coords) (v- (send (send *fetch* :rarm-end-coords) :worldpos) (send (send *fetch* :head-end-coords) :worldpos))), used on look-at inverse-kinematics-loop-for-look-at calculation, before and after changes, respectively, when submitted to:

(send *fetch* :init-pose)
(send *fetch* :look-at-hand :rarm)

BEFORE
look-at-hand-before

AFTER
look-at-hand-after

k-okada added a commit to k-okada/jsk_robot that referenced this pull request Apr 28, 2017
k-okada added a commit to k-okada/jsk_robot that referenced this pull request Apr 28, 2017
k-okada added a commit to k-okada/jsk_robot that referenced this pull request Apr 28, 2017
k-okada added a commit that referenced this pull request Apr 28, 2017
[fetch] Correct head orientation for look-at #771
@k-okada
Copy link
Member

k-okada commented Apr 28, 2017

Thank you, committed with test code #773

@k-okada k-okada closed this Apr 28, 2017
@k-okada k-okada deleted the Affonso-Gui-patch-5 branch April 28, 2017 08:36
@k-okada
Copy link
Member

k-okada commented Apr 28, 2017

@Affonso-Gui please create branches within your repository.

screenshot from 2017-04-28 21 07 33

@Affonso-Gui
Copy link
Member Author

Sorry about that, my mistake.

@knorth55
Copy link
Member

knorth55 commented May 24, 2017

Can you remove these branches?

jsk_robot_branch

@k-okada
Copy link
Member

k-okada commented May 25, 2017

I have removed closed/merged branch, @Affonso-Gui please check
dce7806
00c44be
b4421e8

@Affonso-Gui
Copy link
Member Author

@k-okada Checked.
@knorth55 Deleted 1 to 4. patch5 seems to still be active on #774 . (Apologize for the mistake on uploading several similar and with non-clear name branchs)

@pazeshun
Copy link
Contributor

pazeshun commented May 25, 2017

You can change PR branch.
So you can move patch5 branch to your fork repository, change PR branch to that branch and remove patch5 from this repository.

Sorry, fake information...
You can just make new PR with the branch in your fork repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants