Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to transform markers on rviz #661

Merged

Conversation

wkentaro
Copy link
Member

@wkentaro wkentaro commented Feb 2, 2017

003
009
018

@wkentaro
Copy link
Member Author

wkentaro commented Feb 2, 2017

@mmurooka Could you please review this?

@mmurooka
Copy link
Member

mmurooka commented Feb 2, 2017

Seems OK.

@k-okada k-okada added the MergeOK label Feb 3, 2017
@k-okada
Copy link
Member

k-okada commented Feb 3, 2017

Waiting for Travis

@wkentaro wkentaro closed this Feb 3, 2017
@wkentaro wkentaro reopened this Feb 3, 2017
@wkentaro
Copy link
Member Author

wkentaro commented Feb 3, 2017

jsk_interactive_marker depends on jsk_rviz_plugins, so I can' make build pass. The dependency of jsk_rviz_plugins on jsk_interactive_marker is desired.

jsk_interactive_marker

  • needs jsk_rviz_plugins/TransformableMarkerOperate srv.

jsk_rviz_plugins

  • needs jsk_interactive_marker/GetMarkerDimensions srv.

@wkentaro
Copy link
Member Author

wkentaro commented Feb 3, 2017

I'm moving srv files to jsk_gui_msgs. Do you agree? @k-okada

@k-okada
Copy link
Member

k-okada commented Feb 3, 2017

in, jsk_gui_msgs gui means smartphone/tablet, how about moving interactive marker related rviz plugins to jsk_interactive_marker package.

@wkentaro
Copy link
Member Author

wkentaro commented Feb 3, 2017

I agree.

@wkentaro
Copy link
Member Author

wkentaro commented Feb 3, 2017

@k-okada Could you give me write acess to jsk_visualizatioin? I'd like to restart travis on the web.

@wkentaro wkentaro self-assigned this Feb 3, 2017
@wkentaro wkentaro force-pushed the transformable_markers_rviz_panel_transform branch from 4bba358 to c77e4d8 Compare February 4, 2017 08:43
@wkentaro
Copy link
Member Author

wkentaro commented Feb 4, 2017

Could you merge this?

@k-okada Unexpectedly the merge button is enabled on my GUI. Could you please check the rights?

@k-okada k-okada merged commit bea20e7 into jsk-ros-pkg:master Feb 4, 2017
@k-okada
Copy link
Member

k-okada commented Feb 4, 2017 via email

@wkentaro wkentaro deleted the transformable_markers_rviz_panel_transform branch February 4, 2017 13:11
@wkentaro
Copy link
Member Author

wkentaro commented Feb 4, 2017

Now it works, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants