Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_rqt_plugins/HistogramPlot] modify to correctly run on kinetic #688

Merged
merged 4 commits into from
Sep 3, 2018

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Mar 15, 2018

Kinetic uses qt5, and qt5 has different module structure.
I refactor codes and update to use correct module for kinetic.
You can check with

roslaunch jsk_perception sample_bof_object_recognition.launch
# or
roslaunch jsk_rqt_plugins sample_histogram.launch

bof_histogram

@knorth55 knorth55 changed the title [jsk_rqt_plugins/HistogramPlot] import correct module of qt5 in kinetic [jsk_rqt_plugins/HistogramPlot] modify to correctly run on kinetic Mar 15, 2018
@k-okada k-okada requested a review from iory July 23, 2018 03:21
@k-okada k-okada merged commit 79dcedf into jsk-ros-pkg:master Sep 3, 2018
@knorth55 knorth55 deleted the kinetic-hist branch September 3, 2018 13:10
@iory
Copy link
Member

iory commented Sep 3, 2018

@k-okada
Related to #689 ,
An error occurs with kinetic if you not install matplotlib version (2.2.3). This is not apt version. apt version is 1.5.1

@k-okada
Copy link
Member

k-okada commented Sep 4, 2018

@iroy do you men we should revert this? if so please add +1 to #704, and also please try to write the test code so that Travis find this error. I think just to write test script that import this file would be ok.

@knorth55 please rewrite the code with system matlab version for now. and if you can find the code to support both system (apt) version and pip version, then create new pull requests.

@knorth55
Copy link
Member Author

knorth55 commented Sep 4, 2018

@k-okada apt matplotlib have error with qt5 (see #688).
In order to prevent the error, we have to remove matplotlib dependency.

@knorth55
Copy link
Member Author

knorth55 commented Sep 4, 2018

or install matplotlib 2.0.0 with catkin_virtualenv.

@k-okada
Copy link
Member

k-okada commented Sep 4, 2018 via email

@knorth55
Copy link
Member Author

knorth55 commented Sep 4, 2018

@k-okada thank you, I found the solution.
I will make a PR for solving the problem.
https://github.com/ros-visualization/rqt_plot/blob/master/src/rqt_plot/data_plot/mat_data_plot.py#L62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants