Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_rqt_plugins] fix hist.py to work on kinetic #707

Merged
merged 1 commit into from
Sep 7, 2018

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Sep 6, 2018

this PR is improved PR of #688.
it works with matplotlib 1.5.1

@knorth55
Copy link
Member Author

knorth55 commented Sep 6, 2018

@iory can you check again with this PR?
I think the problem about matplotlib is solved.

@iory
Copy link
Member

iory commented Sep 6, 2018

I also checked this PR and it works too!

image

@k-okada
Copy link
Member

k-okada commented Sep 7, 2018 via email

@knorth55
Copy link
Member Author

knorth55 commented Sep 7, 2018

For python syntax check, I use flake8 + hacking ref: https://qiita.com/kitsuyui/items/5ab4608003a29ff7689f.
it uses openstack hacking guideline. https://docs.openstack.org/hacking/latest/
However, for normal users, roslint_python is enough.

@k-okada k-okada merged commit 0770560 into jsk-ros-pkg:master Sep 7, 2018
@k-okada
Copy link
Member

k-okada commented Sep 7, 2018

Please add them to the Travis CI, if you want to keep changing coding style for every PR,

@knorth55 knorth55 deleted the kinetic-hist branch September 7, 2018 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants