Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_rviz_plugins] Add "Align Bottom" option to OverlayText #723

Merged
merged 6 commits into from Dec 18, 2018

Conversation

YutoUchimi
Copy link
Contributor

@YutoUchimi YutoUchimi commented Dec 14, 2018

This PR mainly focuses on improving visualization of ROS console output on Rviz.

1. Align Bottom option

Before this PR, OverlayText plugin showed text only at the top of the window.

screenshot from 2018-12-14 17-00-58

With this PR, users can select the place of drawn text by toggling AlignBottom checkbox.

screenshot from 2018-12-14 16-58-24

2. ~reverse_lines parameter

This PR also supports a new parameter in rosconsole_overlay_text.py.
In default, the order of output messages shown in rviz is reversed. For example,

2018/12/14 17:57:42 baz
2018/12/14 17:57:41 bar
2018/12/14 17:57:40 foo

However, if set this paramter to false, you will see

2018/12/14 17:57:40 foo
2018/12/14 17:57:41 bar
2018/12/14 17:57:42 baz

Progress

  • Add align bottom option
  • Support reversing lines
  • Add documentation

@YutoUchimi YutoUchimi changed the title [WIP] [jsk_rviz_plugins] Add "Align Bottom" option to OverlayText [jsk_rviz_plugins] Add "Align Bottom" option to OverlayText Dec 14, 2018
@iory iory self-requested a review December 14, 2018 15:53
@k-okada
Copy link
Member

k-okada commented Dec 17, 2018

I can not see 'Align Bottom" option' on doc/jsk_rviz_plugins/nodes/images/rosconsole_overlay_text.png

@YutoUchimi
Copy link
Contributor Author

@k-okada Thank you for your comment.
I updated the image just now.

@k-okada
Copy link
Member

k-okada commented Dec 17, 2018

image
seems much better for me, what the reason not to use this image ?

@YutoUchimi
Copy link
Contributor Author

That image is not the result of roslaunch jsk_rviz_plugins overlay_sample.launch.
This is why I don't use it, but I won't stick to my rule. So I will update to use the image you suggested.

@k-okada
Copy link
Member

k-okada commented Dec 17, 2018 via email

@k-okada k-okada merged commit 05867d8 into jsk-ros-pkg:master Dec 18, 2018
@YutoUchimi YutoUchimi deleted the overlay_text_align_bottom branch December 18, 2018 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants