New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jsk_rviz_plugins] Add "Align Bottom" option to OverlayText #723
Merged
k-okada
merged 6 commits into
jsk-ros-pkg:master
from
YutoUchimi:overlay_text_align_bottom
Dec 18, 2018
Merged
[jsk_rviz_plugins] Add "Align Bottom" option to OverlayText #723
k-okada
merged 6 commits into
jsk-ros-pkg:master
from
YutoUchimi:overlay_text_align_bottom
Dec 18, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YutoUchimi
changed the title
[WIP] [jsk_rviz_plugins] Add "Align Bottom" option to OverlayText
[jsk_rviz_plugins] Add "Align Bottom" option to OverlayText
Dec 14, 2018
iory
approved these changes
Dec 14, 2018
I can not see 'Align Bottom" option' on doc/jsk_rviz_plugins/nodes/images/rosconsole_overlay_text.png |
@k-okada Thank you for your comment. |
That image is not the result of |
YutoUchimi
force-pushed
the
overlay_text_align_bottom
branch
from
December 17, 2018 09:02
8f776e5
to
d71fea3
Compare
ok, if so, please increase the number of vertical line of
overlay_sample.launch, so that uses can easy understand the effect of
'Align bottom'
…--
◉ Kei Okada
--
◉ Kei Okada
2018年12月17日(月) 17:59 Yuto Uchimi <notifications@github.com>:
That image is not the result of roslaunch jsk_rviz_plugins overlay_sample.launch.
This is why I don't use it, but I won't stick to my rule. So I will update to use the image you suggested.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly focuses on improving visualization of ROS console output on Rviz.
1. Align Bottom option
Before this PR,
OverlayText
plugin showed text only at the top of the window.With this PR, users can select the place of drawn text by toggling
AlignBottom
checkbox.2. ~reverse_lines parameter
This PR also supports a new parameter in
rosconsole_overlay_text.py
.In default, the order of output messages shown in rviz is reversed. For example,
However, if set this paramter to false, you will see
Progress