Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsk_rqt_plugins] add service_type and support Trigger for rqt service button #791

Merged
merged 2 commits into from Nov 18, 2020
Merged

[jsk_rqt_plugins] add service_type and support Trigger for rqt service button #791

merged 2 commits into from Nov 18, 2020

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Nov 16, 2020 •
edited

add service_type in rqt_service_buttons and rqt_service_radio_buttons.
with this PR, we can use std_srvs/Empty and std_srvs/Trigger

- name: 'Trigger button'
  service: 'trigger'
  service_type: 'Trigger'
  column: 0
- name: 'Empty button'
  service: 'empty'
  service_type: 'Empty'
  column: 0

@knorth55 knorth55 mentioned this pull request Nov 17, 2020
Merged
@knorth55 knorth55 requested a review from iory November 17, 2020 09:38
@knorth55
Copy link
Member Author

@k-okada Travis passed. can you review and merge this PR?

@k-okada k-okada merged commit a01bcb9 into jsk-ros-pkg:master Nov 18, 2020
@knorth55 knorth55 deleted the support-trigger branch November 19, 2020 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iory iory iory approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knorth55 @iory @k-okada