Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsk_rqt_plugins] Support SetBool for Service Buttons #792

Merged
merged 3 commits into from
Nov 22, 2020
Merged

[jsk_rqt_plugins] Support SetBool for Service Buttons #792

merged 3 commits into from
Nov 22, 2020

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Nov 17, 2020 •
edited
Loading

merge after #780 and #791

Support SetBool service for rqt_service_buttons.

You can try with following command:

roslaunch jsk_rqt_plugins sample_service_buttons.launch

rqt_service_buttons_set_bool

@knorth55 knorth55 requested a review from iory November 17, 2020 09:39
k-okada
k-okada requested changes Nov 18, 2020
View reviewed changes
Copy link
Member

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve conflicts

@knorth55 knorth55 changed the title [Merge after #789 and #791] [jsk_rqt_plugins] Support SetBool for Service Buttons [jsk_rqt_plugins] Support SetBool for Service Buttons Nov 19, 2020
@knorth55
Copy link
Member Author

@k-okada Travis passed, and I resolved the conflict. Can you merge this PR?

@k-okada k-okada merged commit 8eb6517 into jsk-ros-pkg:master Nov 22, 2020
@knorth55 knorth55 deleted the support-set-bool branch November 22, 2020 12:38
@Naoki-Hiraoka
Copy link
Contributor

@k-okada

I use this!
I would appreciate it if you could release this.

Screenshot from 2020-12-14 16-51-38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-okada k-okada k-okada requested changes

@iory iory iory approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@knorth55 @Naoki-Hiraoka @k-okada @iory