Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined method `parser' for Parser:Module after bumping parser dependency to 2.6 #27

Open
michaltrzcinka opened this issue Jan 17, 2019 · 2 comments
Assignees

Comments

@michaltrzcinka
Copy link
Contributor

Describe the bug
After upgrading parser dependency from 2.5.1.2 to 2.6.0.0 (because of Rubocop upgrade), I started to see the following errors from my test suite:

  Failure/Error: klass.parser.parse(klass, connection.run(type, path, params, headers))

     NoMethodError:
       undefined method `parser' for Parser:Module
       Did you mean?  parent
     # /Users/michal/.rvm/gems/ruby-2.5.3/bundler/gems/jsonapi-consumer-7016fe3eb5ee/lib/jsonapi/consumer/included_data.rb:11:in `block (2 levels) in initialize'
     # /Users/michal/.rvm/gems/ruby-2.5.3/bundler/gems/jsonapi-consumer-7016fe3eb5ee/lib/jsonapi/consumer/included_data.rb:10:in `map'
     # /Users/michal/.rvm/gems/ruby-2.5.3/bundler/gems/jsonapi-consumer-7016fe3eb5ee/lib/jsonapi/consumer/included_data.rb:10:in `block in initialize'
     # /Users/michal/.rvm/gems/ruby-2.5.3/bundler/gems/jsonapi-consumer-7016fe3eb5ee/lib/jsonapi/consumer/included_data.rb:8:in `each'
     # /Users/michal/.rvm/gems/ruby-2.5.3/bundler/gems/jsonapi-consumer-7016fe3eb5ee/lib/jsonapi/consumer/included_data.rb:8:in `inject'
     # /Users/michal/.rvm/gems/ruby-2.5.3/bundler/gems/jsonapi-consumer-7016fe3eb5ee/lib/jsonapi/consumer/included_data.rb:8:in `initialize'
     # /Users/michal/.rvm/gems/ruby-2.5.3/bundler/gems/jsonapi-consumer-7016fe3eb5ee/lib/jsonapi/consumer/parsers/parser.rb:108:in `new'
     # /Users/michal/.rvm/gems/ruby-2.5.3/bundler/gems/jsonapi-consumer-7016fe3eb5ee/lib/jsonapi/consumer/parsers/parser.rb:108:in `handle_included'
     # /Users/michal/.rvm/gems/ruby-2.5.3/bundler/gems/jsonapi-consumer-7016fe3eb5ee/lib/jsonapi/consumer/parsers/parser.rb:18:in `block in parse'
     # /Users/michal/.rvm/gems/ruby-2.5.3/bundler/gems/jsonapi-consumer-7016fe3eb5ee/lib/jsonapi/consumer/parsers/parser.rb:8:in `tap'
     # /Users/michal/.rvm/gems/ruby-2.5.3/bundler/gems/jsonapi-consumer-7016fe3eb5ee/lib/jsonapi/consumer/parsers/parser.rb:8:in `parse'
     # ./app/resources/custom_requestor.rb:22:in `request'
     # /Users/michal/.rvm/gems/ruby-2.5.3/bundler/gems/jsonapi-consumer-7016fe3eb5ee/lib/jsonapi/consumer/query/requestor.rb:28:in `get'
     # /Users/michal/.rvm/gems/ruby-2.5.3/bundler/gems/jsonapi-consumer-7016fe3eb5ee/lib/jsonapi/consumer/query/builder.rb:102:in `find'
     # ./app/controllers/stores_controller.rb:192:in `set_store'

To Reproduce
Steps to reproduce the behavior:

  1. Upgrade parser dependency
  2. Run any code which uses included_data.rb

Expected behavior
No error should occur.

Screenshots
N/A

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context

My guess is that JSON-API Consumer is incompatible with the new version of parser gem, which came out yesterday.

@michaltrzcinka
Copy link
Contributor Author

Actually, the problem persists even if I fix the parser dependency to 2.5.1.2. So the problem seems result from Rubocop upgrade - from 0.58.2 to 0.60.

@jsmestad
Copy link
Owner

@michaltrzcinka I am in the middle of moving overseas. Could you take a stab at a fix? If you cannot, I should have time to get to this in a few weeks.

@jsmestad jsmestad self-assigned this Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants