Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly set (peer?)dependency for moment #143

Open
jlsjonas opened this issue May 28, 2020 · 0 comments · May be fixed by #145
Open

Correctly set (peer?)dependency for moment #143

jlsjonas opened this issue May 28, 2020 · 0 comments · May be fixed by #145

Comments

@jlsjonas
Copy link

jlsjonas commented May 28, 2020 •
edited
Loading

strict resolve checking uncovered that the package.json file is missing the fact that this module actually requires moment.
While this is quite obvious (as it's a moment plugin) it should still declare this in it's package.json
jlsjonas added a commit to jlsjonas/moment-duration-format that referenced this issue Jun 2, 2020
@jlsjonas
Mark moment as peerDependency
c6f7a91 
Fixes jsmreese#143
@jlsjonas jlsjonas linked a pull request Jun 2, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark moment as peerDependency jlsjonas/moment-duration-format
1 participant
@jlsjonas