Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

git description #26

Closed
ilg-ul opened this Issue Oct 30, 2012 · 1 comment

Comments

Projects
None yet
2 participants

ilg-ul commented Oct 30, 2012

I updated my build script to use the latest version (it works fine), and I also updated it to clone the repos instead of fetching the archive.

after this change I noticed the PKG_VERSION looks unusual, for example:

gcc version 4.6.3 (32-bit ARM EABI Toolchain CS-2012.03-56-v2011.09-69-17-ge3f4013) 

I checked and the last part comes from the output of 'git description'

v2011.09-69-17-ge3f4013

I personally consider this not very usefull, since, as can be seen here, it is out of date.

so I applied a small patch, to make the BUILD_ID also externally configurable:

--- Makefile    2012-10-30 21:56:07.000000000 +0200
+++ ../../Makefile  2012-10-30 21:56:42.000000000 +0200
@@ -66,7 +66,7 @@


 ####    BUILD LABELING / TAGGING      #####
-BUILD_ID   = $(shell git describe --always)
+BUILD_ID   ?= $(shell git describe --always)
 TODAY           = $(shell date "+%Y%m%d")

 ifeq ($(strip $(BUILD_ID)),)

in my script I initialise it with the short git id:

export BUILD_ID="e3f4013"

if you think useful, you can use this patch in your next release.

regards,

Liviu

@jsnyder jsnyder closed this in d53ce5a Nov 1, 2012

Owner

jsnyder commented Nov 1, 2012

Thanks. I've been somewhat busy and just included the updated version but didn't update the tags. I'll try and come up with something cleaner when I get around to some work on this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment