New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for django-jinja. #167
Conversation
This moves to Jinja2 helpers to templatetags/jinja_waffle_tags.py so that the django infra always imports the file and they get loaded. It tries using both jingo and django-jinja. This also adds testing with Django 1.8 to the tox settings. Django 1.8 is only tested with django-jinja.
hmm, I need to tweak travis.yml to run django 1.8... On it. |
'DIRS': [], | ||
'APP_DIRS': True, | ||
'OPTIONS': { | ||
"match_regex": r"jingo.*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: This uses " but should use '.
I think this looks ok. I had some minor nits but they're probably not that important. The one thing I was thinking about was whether truncating Maybe that's academic, though. @jsocol If there's anything else I can do here, let me know. I don't want to rush you, but the sooner this lands, the better. I'm totally game for trading favors (e.g. you spend some time on this and I spend some time helping you with something else) if that helps. |
This has been around for a month and a half now. We need to move forward, so I'm going to fork django-waffle for now and we'll use my fork. If there's anything I can do to help get this landed, let me know. |
I added @willkg to this repo—we talked about it offline a little while ago and I think it slipped off both our plates. I'm actively looking for more help maintaining this and a few other repos, too. That said, the next release has got to be 0.10.2, then I'll get to #137 in 0.10.3, I guess, before wrapping up the work in 0.11. |
This moves the Jinja2 helpers to templatetags/jinja_waffle_tags.py
so that the django infra always imports the file and they get loaded.
It tries using both jingo and django-jinja.
This also adds testing with Django 1.8 to the tox settings. Django 1.8
is only tested with django-jinja.
r?