Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for django-jinja. #167

Closed
wants to merge 3 commits into from
Closed

Conversation

rlr
Copy link
Contributor

@rlr rlr commented Jun 4, 2015

This moves the Jinja2 helpers to templatetags/jinja_waffle_tags.py
so that the django infra always imports the file and they get loaded.
It tries using both jingo and django-jinja.

This also adds testing with Django 1.8 to the tox settings. Django 1.8
is only tested with django-jinja.

r?

This moves to Jinja2 helpers to templatetags/jinja_waffle_tags.py
so that the django infra always imports the file and they get loaded.
It tries using both jingo and django-jinja.

This also adds testing with Django 1.8 to the tox settings. Django 1.8
is only tested with django-jinja.
@rlr
Copy link
Contributor Author

rlr commented Jun 4, 2015

hmm, I need to tweak travis.yml to run django 1.8... On it.

'DIRS': [],
'APP_DIRS': True,
'OPTIONS': {
"match_regex": r"jingo.*",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This uses " but should use '.

@willkg
Copy link
Collaborator

willkg commented Jun 9, 2015

I think this looks ok. I had some minor nits but they're probably not that important.

The one thing I was thinking about was whether truncating waffle/helpers.py and then moving that code to waffle/templatetags/jinja_template_tags.py was a good idea or whether it'd be better to have the jingo specific code in waffle/helpers.py and not mix it with the django-jinja stuff in waffle/templatetags/jinja_template_tags.py.

Maybe that's academic, though.

@jsocol If there's anything else I can do here, let me know. I don't want to rush you, but the sooner this lands, the better. I'm totally game for trading favors (e.g. you spend some time on this and I spend some time helping you with something else) if that helps.

@willkg
Copy link
Collaborator

willkg commented Jul 21, 2015

This has been around for a month and a half now. We need to move forward, so I'm going to fork django-waffle for now and we'll use my fork.

If there's anything I can do to help get this landed, let me know.

@jsocol
Copy link
Collaborator

jsocol commented Jul 21, 2015

I added @willkg to this repo—we talked about it offline a little while ago and I think it slipped off both our plates. I'm actively looking for more help maintaining this and a few other repos, too.

That said, the next release has got to be 0.10.2, then I'll get to #137 in 0.10.3, I guess, before wrapping up the work in 0.11.

@willkg willkg mentioned this pull request Oct 20, 2015
@jsocol jsocol mentioned this pull request Oct 20, 2015
@willkg
Copy link
Collaborator

willkg commented Oct 20, 2015

I'm a huge fan of what @jsocol just did with #180. Given that solves the problems we were solving here, I'm closing this one out.

@willkg willkg closed this Oct 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants