Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: custom query string parameters do not respect casing convention #719

Closed
bart-degreed opened this issue Apr 8, 2020 · 1 comment · Fixed by #837
Closed

Bug: custom query string parameters do not respect casing convention #719

bart-degreed opened this issue Apr 8, 2020 · 1 comment · Fixed by #837
Assignees
Labels

Comments

@bart-degreed
Copy link
Contributor

Currently we use case-insensitive string comparisons around DisableQueryAttribute, which works with the default camel case convention, but breaks when switching to kebab casing.

We should have a test that uses a custom query string parameter that consists of multiple words.

@bart-degreed
Copy link
Contributor Author

After discussion, @maurei and I decided to not apply casing conventions on custom parameter names. Because the API developer is in full control here: he/she chooses the casing convention and is then responsible to apply the same casing for custom parameters.

However, keeping this open to remove the case-insensitive comparisons for built-in parameters such as sort/filter/page etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

1 participant