Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-data link on implementations page is broken #1706

Open
conormag opened this issue Jul 3, 2023 · 2 comments
Open

ember-data link on implementations page is broken #1706

conormag opened this issue Jul 3, 2023 · 2 comments

Comments

@conormag
Copy link

conormag commented Jul 3, 2023

didnt check any others - just ember-data. current link is https://api.emberjs.com/ember-data/release/modules/@ember-data%2Fjson-api

@jelhan
Copy link
Contributor

jelhan commented Jul 4, 2023

What do you mean by broken? Implementation page contains the following link for Ember Data: https://github.com/emberjs/data That link points to the GitHub repository used by that project. We could include the API documentation for one of its classes as well. But for most other implementations links to the GitHub repositories are used as well. I tend towards keeping that for consistency.

@conormag
Copy link
Author

conormag commented Jul 4, 2023

yes sorry it was unclear. there is a link in the second sentence to the "official adapter" which points to the ember-data adapter in the ember docs. the ember api docs give a 404 for that link. it is now https://api.emberjs.com/ember-data/release/modules/@ember-data%2Fadapter%2Fjson-api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@conormag @jelhan and others