Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where's the test suite being assembled? #789

Closed
kevmoo opened this issue Jun 27, 2015 · 8 comments
Closed

Where's the test suite being assembled? #789

kevmoo opened this issue Jun 27, 2015 · 8 comments

Comments

@kevmoo
Copy link

kevmoo commented Jun 27, 2015

...but a test suite is now being assembled to vet them. - http://jsonapi.org/implementations/

@tkellen
Copy link
Member

tkellen commented Jun 29, 2015

endpoints/endpoints#125

@tkellen
Copy link
Member

tkellen commented Jun 29, 2015

Please feel free to open issues over @ endpoints for this!

@tkellen tkellen closed this as completed Jun 29, 2015
@gr0uch
Copy link
Contributor

gr0uch commented Jun 29, 2015

There's tests here as well.

@kevmoo
Copy link
Author

kevmoo commented Jun 29, 2015

@tkellen @0x8890 Will https://github.com/endpoints/endpoints be the canonical local for tests?

That should be documented as part of json-api. Having a model for interop testing is as important – arguably more important – than the spec.

@tkellen
Copy link
Member

tkellen commented Jun 29, 2015

We're currently developing the integration suite against endpoints using https://github.com/json-api/json-api/blob/gh-pages/normative-statements.json. Once this is complete, we'll move it out to json-api and figure out how we can generalize it far enough to be pointed at any API. One hitch is that implementors will need to use http://github.com/endpoints/fantasy-database for their API. We don't support hypermedia quite well enough for the integration suite to be entirely generic.

@kevmoo
Copy link
Author

kevmoo commented Jun 29, 2015

@tkellen Great news.

I don't mind having to run tests with nodejs against my own impl.

@kevmoo
Copy link
Author

kevmoo commented Jun 29, 2015

@tkellen Could we make this bug – or another – a tracking issue for tests? Call it an "enhancement request".

@gr0uch
Copy link
Contributor

gr0uch commented Jun 29, 2015

It would not be too difficult to generalize testing, the implementation would just need to be aware of what types will be used for testing.

This is how I implemented tests:

  1. Create all resources by posting to the API.
  2. Run test.
  3. Delete all resources by making delete requests. Repeat.

Note: not all tests need to run/pass, depending on the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants