Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of "json" for headers and the library clashes with other implementations #17

Closed
kdopen opened this issue Mar 30, 2012 · 2 comments
Closed

Comments

@kdopen
Copy link
Contributor

kdopen commented Mar 30, 2012

When building large systems, using many third party components, it is not unusual to have a number of different JSON implementations. If more than one lays claim to the .../json directory name, then it is necessary to maintain a private fork to contain a modified set of build and install scripts/makefiles. A similar situation occurs with the use of libjson for the library.

json-c should use a unique name-space for its installed artifacts, preferably

.../include/json-c and
.../lib/libjson-c

@hawicz
Copy link
Member

hawicz commented Mar 31, 2012

This is a duplicate of Issue #5.

@hawicz hawicz closed this as completed Mar 31, 2012
@mloskot
Copy link
Contributor

mloskot commented Feb 25, 2013

Does this "json-c should use a unique name-space for its installed artifacts" mean this approach has been already implemented, or it is a guideline?

I've just noticed, make install for current master installs headers in two separate locations:

  • old
$ ls /usr/local/include/json/
arraylist.h             json_c_version.h        json_object_iterator.h  linkhash.h
bits.h                  json.h                  json_object_private.h   printbuf.h
debug.h                 json_inttypes.h         json_tokener.h          
json_config.h           json_object.h           json_util.h             

$ grep '\#define JSON_C_VERSION ' /usr/local/include/json/*
/usr/local/include/json/json_c_version.h:#define JSON_C_VERSION "0.10.99"
  • new or recommended
$ ls /usr/local/include/json-c/
arraylist.h             json_c_version.h        json_object_iterator.h  linkhash.h
bits.h                  json.h                  json_object_private.h   printbuf.h
debug.h                 json_inttypes.h         json_tokener.h          
json_config.h           json_object.h           json_util.h             

$ grep '\#define JSON_C_VERSION ' /usr/local/include/json-c/*
/usr/local/include/json-c/json_c_version.h:#define JSON_C_VERSION "0.10.99"

Is that expected behaviour?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants