Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only GCC-specific flags when compiling with GCC #184

Closed
wants to merge 2 commits into from

Conversation

dago
Copy link

@dago dago commented May 20, 2015

Hi,

these are some adjustments on the autoconf-foo that enhance the compatibility with non-GCC compilers.

Best regards -- Dago

@hawicz
Copy link
Member

hawicz commented Jun 3, 2015

Why did you drop AC_C_CONST and AC_TYPE_SIZE_T?

@dago
Copy link
Author

dago commented Jun 3, 2015

I only moved the two lines upwards, I can't remember the reason any more, probably because the manual suggested to have these tests early and before the header checks.

@hawicz
Copy link
Member

hawicz commented Nov 15, 2015

The use of gcc specific flags on non-gcc compilers should be fixed by changeset 80c1f69
For anything else that's needed, please submit a separate pull request. However, munging the scripts to support lackluster shells leaves a bad taste in my mouth. If you can instead arrange for the tests to be executed with a fully working shell I'd be much happier to merge the change.

@hawicz hawicz closed this Nov 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants