Fix #165 #243
Merged
Fix #165 #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function fstat isn't declared without this include on debian strect/sid and Fedora-23 Change-Id: I660a32ff173dcba04674aed51ed855b4fa55ac67 Signed-off-by: José Bollo <jose.bollo@iot.bzh>
This new method allows to also get the length of the generated string. Fix json-c#165 Change-Id: Iea91404027f143ca3d29a4c58d7c07ae53556110 Signed-off-by: José Bollo <jose.bollo@iot.bzh>
|
I'm not particularly thrilled about the name, but I can't think of a better one, so ok I'll merge this. However, do you have any tests for this? Adding a new feature without anything in the tests that actually checks that it works isn't so great. |
|
Maybe you prefer 'json_object_to_json_string_len' ? |
The test is implied in test1. The idea is to check that the returned lengths and strings are identical to what is expected to return the already tested function 'json_object_to_json_string_ext'. Signed-off-by: José Bollo <jose.bollo@iot.bzh>
|
done in a way that may hurt but ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.