Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a file for EditorConfig #251

Merged
merged 1 commit into from Aug 13, 2016
Merged

Adding a file for EditorConfig #251

merged 1 commit into from Aug 13, 2016

Conversation

ghost
Copy link

@ghost ghost commented Aug 7, 2016

No description provided.

@hawicz hawicz closed this Aug 7, 2016
@hawicz hawicz reopened this Aug 7, 2016
@hawicz
Copy link
Member

hawicz commented Aug 7, 2016

That notice at the top, which doesn't include a copyright, is a bit odd. Is there some reason that the standard MIT license doesn't apply to this file?

@hawicz hawicz mentioned this pull request Aug 7, 2016
@ghost
Copy link
Author

ghost commented Aug 8, 2016

There is no "MIT license".
https://www.gnu.org/licenses/license-list.en.html#X11License
https://www.gnu.org/licenses/license-list.en.html#Expat

Except, the license header, the file is smaller than what you call "the standard MIT license", so I think that this license is too big for such a file. Moreover, this license gives attribution, I don't want it for such a small thing.
It is a slightly modified version of the GNU All-Permissive License. https://www.gnu.org/licenses/license-list.en.html#GNUAllPermissive

@hawicz
Copy link
Member

hawicz commented Aug 10, 2016

In my experience as commonly used, and as I intended it, the phrase "MIT License" refers to a license like https://opensource.org/licenses/MIT, and matching what is in json-c's COPYING file.

gnu.org, though a convenient reference, isn't authoritative for what is and what isn't a valid license or what it is called. However, if you want to use their terminology, please interpret "MIT License" to mean "Expat License".

Whatever you call it is largely irrelevant though, as my complaints with the license in the .editorconfig file are:
1 - although the license seems perfectly fine, introducing another different license into json-c is an unnecessary burden for anyone that needs to analyze them before using the software
2 - to be complete, if we were to consider the changes you're contributing to be significant enough to warrant including a new license, it should include a copyright statement.

@ghost
Copy link
Author

ghost commented Aug 12, 2016

I removed the license notice.

@hawicz hawicz merged commit e076ae7 into json-c:master Aug 13, 2016
@ghost ghost deleted the editorconfig branch August 13, 2016 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant