Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cmakefile and fix compiler warning. #262

Closed
wants to merge 2 commits into from

Conversation

randy-armstrong
Copy link

A cmake file is handy for devs who target multiple OSes including windows.
It has not been tested on non-Windows platforms but it should work.

@hawicz
Copy link
Member

hawicz commented Aug 24, 2016

please split the json_object.c change off separately. (why is that needed?)

@randy-armstrong
Copy link
Author

reverted the changes to json_object.c

It is necessary because code should not have warnings.

@hawicz
Copy link
Member

hawicz commented Aug 25, 2016

I included your change as a single commit c5b5a98.

If you think there's something wrong with the json_object_object_add_ex() function please open a separate ticket and include the actual warning that you're seeing, as it compiles just fine for me.
Also, even if you are seeing some kind of warning, dropping the const qualifiers is almost certainly the wrong fix.

@hawicz hawicz closed this Aug 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants