Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _GNU_SOURCE define for vasprintf #288

Closed
wants to merge 1 commit into from

Conversation

andrenarchy
Copy link

Without the #define it errors with:

error: implicit declaration of function ‘vasprintf’ [-Werror=implicit-function-declaration]
     if((size = vasprintf(&t, msg, ap)) < 0) { va_end(ap); return -1; }

@andrenarchy
Copy link
Author

I used cmake for building. It seems like this is not the preferred way of building this project. Feel free to close this PR if cmake is not yet supported.

@hawicz
Copy link
Member

hawicz commented Nov 20, 2016

Dropping that define in printbuf.c isn't the right way to fix this. Building the normal way (configure, then make) results in -D_GNU_SOURCE being passed on the command line. If you want to fix the cmake build, please try to figure out how to get it to use the same flags that the normal way of building does.

@hawicz hawicz closed this Nov 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants