Fix CMake Build process improved for MinGW and MSYS2 #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix includes some fixes for config.h.win32 that was generating some compiling errors on MinGW64 and also fix CMakeLists.txt in order to give better support to MinGW and MSYS2
Added #ifdef conditions for MinGW because this compiler doesn't define gcc atomic builtins, so __sync_val_compare_and_swap was not found neither any of any __GCC_HAVE_SYNC_COMPARE_AND_SWAP_* definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix includes some fixes for config.h.win32 that was generating
some compiling errors on MinGW64 and also fix CMakeLists.txt in order to
give better support to MinGW and MSYS2
I have added a specific case for MinGW and MSYS2, the first one use the modified config.h.win32 and the other one uses the unix tools installed along with MSYS