Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build,cmake: fix vasprintf implicit definition and generate both static & shared libs #321

Merged
merged 3 commits into from Jun 19, 2017
Merged

build,cmake: fix vasprintf implicit definition and generate both static & shared libs #321

merged 3 commits into from Jun 19, 2017

Conversation

commodo
Copy link
Contributor

@commodo commodo commented May 3, 2017

Fixes #298

Signed-off-by: Alexandru Ardelean ardeleanalex@gmail.com

@commodo
build,cmake: add _GNU_SOURCE to CFLAGS
cfbbb23 
Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
@commodo
build,cmake: generate both static and shared libjson
4b5e39c 
Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
@commodo
.gitignore: add cmake generated files
f10a5ae 
Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
@commodo commodo changed the title build,cmake: fix vasprintf implicit definition build,cmake: fix vasprintf implicit definition and generate both static & shared libs May 3, 2017
@commodo
Copy link
Contributor Author

commodo commented May 3, 2017

maybe it's a bit over-board/a lot
but i also squeezed into this PR the change for cmake to generate both static & shared lib
apparently, it was only generating static libs before

@hawicz hawicz merged commit a363969 into json-c:master Jun 19, 2017
@commodo commodo deleted the fix-cmake-vasprintf branch June 19, 2017 06:25
@ploxiln
Copy link
Contributor

ploxiln commented Jun 19, 2017

Does this generate libjson-c-static.a instead of libjson-c.a? Meaning the name of the static library is different?

@commodo
Copy link
Contributor Author

commodo commented Jun 19, 2017

yep ;
i admit i did not put much effort in trying to identify a way to see how to generate a static lib that's called libjson-c.a

will look into it

@commodo commodo mentioned this pull request Jun 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@commodo @ploxiln @hawicz