Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix build on appveyor CI #373

Merged
merged 2 commits into from Nov 26, 2017
Merged

build: fix build on appveyor CI #373

merged 2 commits into from Nov 26, 2017

Conversation

commodo
Copy link
Contributor

@commodo commodo commented Nov 7, 2017

Should fix build with Visual Studio.

Signed-off-by: Alexandru Ardelean ardeleanalex@gmail.com

@commodo commodo changed the title strerror_override: make _json_c_strerror() definition available only if STRERROR_OVERRIDE_IMPL strerror_override: make _json_c_strerror() definition available only if STRERROR_OVERRIDE_IMPL not defined Nov 7, 2017
Always include <string.h> before _json_c_strerror() definition.
Should fix linker issues on MSVC.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Got the idea from this blog post:
  http://www.enchantedage.com/node/231

Simple & concise stuff :)

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
@commodo commodo changed the title strerror_override: make _json_c_strerror() definition available only if STRERROR_OVERRIDE_IMPL not defined build: fix build on appveyor CI Nov 7, 2017
@commodo
Copy link
Contributor Author

commodo commented Nov 7, 2017

so, as far as things go, the appveyor build is fixed, but Travis hangs on the OS X build
oh well, let's see

@hawicz hawicz merged commit 0478842 into json-c:master Nov 26, 2017
@commodo commodo deleted the fix-appveyor-build branch November 25, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants