Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: builds involving this target will not be correct #427

Closed
TheAifam5 opened this issue Jun 18, 2018 · 3 comments
Closed

CMake: builds involving this target will not be correct #427

TheAifam5 opened this issue Jun 18, 2018 · 3 comments

Comments

@TheAifam5
Copy link

TheAifam5 commented Jun 18, 2018

Hey!

I'm get an warning when I try to compile it using CMake:
warning: multiple rules generate thirdparty/json-c/json-c.lib. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn]

I think that's because the project does not have switch between static library and dynamic library, and also because of: set_target_properties(json-c-static PROPERTIES OUTPUT_NAME json-c)

Without that set_target_properties I'm don't get any warnings.

Regards,
Mateusz

@ploxiln
Copy link
Contributor

ploxiln commented Jun 18, 2018

looks related to #415

@TheAifam5
Copy link
Author

On windows you try to set the same name for shared and static libraries using ‚set_target_properties‘. Simple if with NOT (MSVC OR MINGW OR WIN32) etc should be enough.

@hawicz
Copy link
Member

hawicz commented Jun 24, 2018

s/b fixed by merging the changes in #415.

@hawicz hawicz closed this as completed Jun 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants