Update README.md #452
Update README.md #452
Conversation
| @@ -72,7 +72,7 @@ $ make USE_VALGRIND=0 check # optionally skip using valgrind | |||
| Install prerequisites <a name="installprereq"></a> | |||
| ----------------------- | |||
|
|
|||
| If you are on a relatively modern system, you'll likely be able to install | |||
| If you are in a relatively modern system, you'll likely be able to install | |||
There was a problem hiding this comment.
"in" is a rather odd way to word this
|
|
||
| For older OS's that don't have up-to-date version of the packages will | ||
| For older OS's that don't have an up-to-date version of the packages will |
There was a problem hiding this comment.
"don't have up-to-date versions" would be better
| @@ -151,7 +151,7 @@ CMake can take a few options. | |||
|
|
|||
| Variable | Type | Description | |||
| ------------------|------|-------------- | |||
| BUILD_SHARED_LIBS | Bool | The default build generates static library. Enable this to generate shared (dll/so) library. | |||
| BUILD_SHARED_LIBS | Bool | The default build generates a static library. Enable this to generate shared (dll/so) library. | |||
There was a problem hiding this comment.
er.. I'm not even sure this description is accurate, and if it is, then it shouldn't be. The default definitely should not be to just build a static library.
There was a problem hiding this comment.
By default, cmake will build one or the other. If BUILD_SHARED_LIBS is ON, then cmake will create a shared library, but not a static library. There are ways to change that behavior though, with only minor editing of CMakeLists.txt apparently. Some info about it here: https://stackoverflow.com/questions/2152077/is-it-possible-to-get-cmake-to-build-both-a-static-and-shared-version-of-the-sam
|
I'm not merging this. Instead, in commit 6460466 I switch the build to create a dynamic library, and made a couple of tweaks to the README file. |
No description provided.