Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists.txt doesn't contain json_object_iterator.h which json.h includes #465

Closed
ttjsu-aws opened this issue Dec 11, 2018 · 2 comments
Closed

Comments

@ttjsu-aws
Copy link

https://github.com/json-c/json-c/blob/master/CMakeLists.txt#L200 missing from CMakeLists.txt in json-c-0.13.

@andy5995
Copy link
Contributor

I don't think that's a problem. Handled when cmake calls autoreconf probably. The build completes. Note the commit message here dated July 23, 3 months after the release of 0.13.

@hawicz
Copy link
Member

hawicz commented Dec 12, 2018

Actually, I think the relevant commit for the style of CMakeLists.txt that's on the 0.13 branch is 37a2edf, but that happened after the most recent 0.13 branch release.
Just because the build completes doesn't mean that everything that's installed is actually usable, and I verified that using cmake to build from the 0.13 branch does result in a broken install.
I copied the fix over as 0daf8dc, so if you really need to build off of that branch you can, but this doesn't warrant a new release.

@hawicz hawicz closed this as completed Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants