New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler warnings #467

Closed

rkalidas wants to merge 1 commit into json-c:master from rkalidas:compiler-fixes

Contributor

rkalidas commented Dec 17, 2018

Compiler complains about missing prototype and undefined macros. It turns into an error when -Werror is turned on and the compilation aborts.


          Fix compiler warnings

c534709

Member

hawicz commented Dec 18, 2018

I'm not merging this because:

lh_char_equal() and lh_ptr_equal should not be exposed in the header file
Unconditionally defining HAVE_RDRAND and HAVE_CRYPTGENRANDOM will cause errors when one of the cases where we have an implementation is triggered.
If you're going to add "void" to function definitions, don't just pick a few, update them all.

hawicz closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment