Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce lines for better optimization #511

Closed
wants to merge 4 commits into from

Conversation

hoaianhkhang
Copy link

No description provided.

@hawicz
Copy link
Member

hawicz commented Dec 11, 2019

"Optimizing" tests is rather pointless. Also, your changes to use my_array_length are wrong, since you never recalculate that value. Finally, this will fail to build on certain old compilers (mainly Visual Studio) due to variable declarations that aren't at the beginning of the functions.
Thanks for the suggestion, but I won't be merging this.

@hawicz hawicz closed this Dec 11, 2019
@hoaianhkhang
Copy link
Author

I see, may I ask is there anything else that I can do to help optimize the program, since I am new I do not really have experience yet.

@hawicz
Copy link
Member

hawicz commented Dec 12, 2019

I would ignore anything to do with the tests, they're not worth "optimizing". If you're new to json-c, I recommend picking some task you might want to do that involves JSON, use the library to perform that task, whatever it might be, and if you find some deficiency in the library only then consider whether there's an improvement or bug fix that you can contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants