New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding type uint64 #520
Comments
This was asked before by @topilski , see #326 Also, any attempt to add additional bits is going to increase overhead and have various tradeoffs, and I'm skeptical that it's worth doing that for just a single bit. On the other hand, if you want to bump things up to 128 bits, then things get more interesting. Either way, I'd expect a characterization from you as to what you believe the benefits and drawbacks are/will be, and why it's justified to include the changes you want. |
I see where you come from regarding adding 64-bit thing. The single benefit: After adding uint64_t capable of functions, there is a working function of "json_object_new_uint64(0xFFFFFFFFFFFFFFFF), and then json_obj.to_string() function correctly produces a right number for it. Trying the 128-bit thing is a very interesting challenge and it is beyond of my capability. Hope you understand. |
Closing this, since #542 has been merged. It adds support for uint64_t w/o adding a new json_type. Overflow should be handled reasonably, by capping at UINT64_MAX, while negative values still end up being returned as 0. |
I've enhanced the code with adding uint64 functions in my local branch. This uint64 type is needed for my project that needs to handling a full data value of a 64-bit register from a hardware module.
I would like to share my enhancements. What are the steps for me to do to make a pull-request?
--JC
The text was updated successfully, but these errors were encountered: