Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase coverage #524

Merged
merged 4 commits into from
Apr 16, 2020
Merged

Increase coverage #524

merged 4 commits into from
Apr 16, 2020

Conversation

dota17
Copy link
Member

@dota17 dota17 commented Jan 3, 2020

No description provided.

@coveralls
Copy link

coveralls commented Apr 14, 2020 •
edited
Loading

Coverage Status

Coverage increased (+1.3%) to 85.924% when pulling b14363a on dota17:addTestCase_obj_token into 7fb8d56 on json-c:master.

hawicz
hawicz reviewed Apr 14, 2020
View reviewed changes
tests/test_util_file.c Outdated Show resolved Hide resolved
tests/test_util_file.c Outdated Show resolved Hide resolved
tests/test_util_file.c Outdated Show resolved Hide resolved
@dota17
Copy link
Member Author

dota17 commented Apr 15, 2020

For increasing the line coverage, I tested these special error scenarioes before, like the wrong value of json_type, nonexistent file "./test_cast.test". emmmm, it seems a bit inappropriate and far-fetched now. I have removed these.

@hawicz hawicz merged commit a911439 into json-c:master Apr 16, 2020
@dota17 dota17 deleted the addTestCase_obj_token branch April 17, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawicz hawicz hawicz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dota17 @coveralls @hawicz