Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve issue #108. Skip \u0000 while parsing. #528

Closed
wants to merge 1 commit into from

Conversation

dota17
Copy link
Member

@dota17 dota17 commented Jan 10, 2020

As discussed in #108. \u0000 was skipped during token analysis.Did not escape \u0000 to \0.

@hawicz
Copy link
Member

hawicz commented Jan 10, 2020

Sorry, I can't merge this. It's quite a hack that will break any existing usage that happens to handle json strings like:

"x\\u0000x"

That'll turn into the 8 in-memory bytes: x, \ , u, 0, 0, 0, 0, x
Which, with your changes, will then incorrectly be serialized into:

"x\u0000x"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants