Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uninstall target in cmake #546

Merged
merged 2 commits into from Mar 11, 2020
Merged

Add uninstall target in cmake #546

merged 2 commits into from Mar 11, 2020

Conversation

dota17
Copy link
Member

@dota17 dota17 commented Feb 27, 2020

Add uninstall target in cmake

@dota17
Copy link
Member Author

dota17 commented Mar 9, 2020

hi, hawicz
I have added several cmake features before. What else do you think needs to be added in cmake?

@hawicz
Copy link
Member

hawicz commented Mar 10, 2020

er... that's odd, I could have sworn I had commented on this change.
Anyway: using the -r option to rm is unnecessary and dangerous. The contents of install_manifest.txt look like it's just files, not directories, and even if it were directories you wouldn't want to remove them if they happened to contain non-json-c files in them.

@dota17
Copy link
Member Author

dota17 commented Mar 10, 2020

I have modified the make_uninstall in CMakeLists.txt and added the cmake/cmake_uninstall.cmake.in file according the official manual

@hawicz
Copy link
Member

hawicz commented Mar 11, 2020

oof, that's a whole pile of complexity for a marginally useful feature. :( Sure, they might recommend that for "cross platform compatibility", but let's not drink all the kool aid.
Please feed the contents of install_manifest to rm like you were doing before, just without the "-r" option to recurse.

@dota17
Copy link
Member Author

dota17 commented Mar 11, 2020

ok, finished

@hawicz hawicz merged commit e94eb90 into json-c:master Mar 11, 2020
@dota17 dota17 deleted the make_unistall branch April 17, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants