Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hexadecimal number format convention parsing #551

Closed
wants to merge 1 commit into from

Conversation

nitzancarmi
Copy link

Allow parsing of the hexadecimal number standard
format (e.g. 0x<number>).

Signed-off-by: Nitzan Carmi nitzanc@mellanox.com

@nitzancarmi nitzancarmi force-pushed the hex_prefix_support branch 4 times, most recently from fb874d6 to 16cacc8 Compare March 10, 2020 15:30
Allow parsing of the hexadecimal number standard
format (e.g. `0x<number>`).

Signed-off-by: Nitzan Carmi <nitzanc@mellanox.com>
@dota17
Copy link
Member

dota17 commented Mar 11, 2020

1, Standard json do not support octal and hexadecimal number.
A number is very much like a C or Java number, except that the octal and hexadecimal formats are not used. https://www.json.org/
2, Maybe you should add the test cases to verify your function implementation.

@hawicz
Copy link
Member

hawicz commented Mar 11, 2020

Sorry, this is totally out of the spec we're aiming for (RFC 7159), and not even in the newer one (RFC 8259), so I don't expect that we'll merge this.

@nitzancarmi
Copy link
Author

Alright then. Tnx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants