Fix/clang ubsan #553
Closed
Fix/clang ubsan #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as an optimizer hint. Also, rename that function from json_object_sizeof().
json_object: Add const size_t json_c_object_sizeof()
This is recommended by the libtool manual.
json_object: Avoid invalid free (and thus a segfault) when ref_count gets < 0
…ro because some custom formats *will* include it (e.g. %.2f). Also try to accomodate formats to explicitly exclude the decimal (e.g. %.0f).
…d conflicts because some downstream packagers of json-c had already done their own bump to ".so.3" for a much older 0.12 release.
Fix json_object_object_foreach to avoid uninitialized variable warnings using ANSI C or MSC.
Conflicts: ChangeLog
…fore adding it to CFLAGS.
Conflicts: ChangeLog
…erated too significantly.
|
Something went wrong here, just had one little change, not 23 commits.... |
|
Looks like you started from a release branch, and tried to submit a pr to merge back to master. I expect that if you create a new branch from master and cherry-pick your commit 6b368fc over then things will work out better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple fix keeps clang -fsanitize=undefined from complaining.