Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes to CMakeLists #572

Merged
merged 3 commits into from Apr 11, 2020
Merged

Small fixes to CMakeLists #572

merged 3 commits into from Apr 11, 2020

Conversation

besser82
Copy link
Contributor

@besser82 besser82 commented Apr 10, 2020 •
edited

  • Fix appending of linker flags.
  • Build Doxygen documentation out-of-tree.
  • Check whether BSYMBOLIC is supported by the linker.

@coveralls
Copy link

coveralls commented Apr 10, 2020 •
edited

Coverage Status

Coverage remained the same at 0.0% when pulling e756777 on besser82:topic/besser82/cmake_fixes into 61392c8 on json-c:master.

hawicz
hawicz reviewed Apr 10, 2020
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@besser82
CMake: Check whether BSYMBOLIC is supported by the linker.
e756777 
Linking with '-Bsymbolic-functions' is supported for ELF-binaries, only.
@besser82 besser82 requested a review from hawicz April 10, 2020 15:36
@hawicz
Copy link
Member

hawicz commented Apr 11, 2020

Awesome, thanks!

@hawicz hawicz merged commit 0734c53 into json-c:master Apr 11, 2020
@hawicz hawicz mentioned this pull request Apr 11, 2020
Closed
@besser82 besser82 deleted the topic/besser82/cmake_fixes branch April 11, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawicz hawicz Awaiting requested review from hawicz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@besser82 @coveralls @hawicz