Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coveralls submission. #573

Merged
merged 1 commit into from Apr 11, 2020
Merged

Fix coveralls submission. #573

merged 1 commit into from Apr 11, 2020

Conversation

besser82
Copy link
Contributor

coveralls-cpp is dead and does not work anymore. Fortunately there is coveralls-lcov available.

@coveralls
Copy link

coveralls commented Apr 10, 2020 •
edited

Coverage Status

Coverage increased (+83.6%) to 83.555% when pulling 0dac15c on besser82:topic/besser82/coverage into 61392c8 on json-c:master.

@hawicz
Copy link
Member

hawicz commented Apr 10, 2020

We're missing a lcov package in the travis config somewhere, probably around line 92 of .travis.yml. Can you add that?

@besser82 besser82 force-pushed the topic/besser82/coverage branch 2 times, most recently from 476c9e1 to 1a314fc Compare April 10, 2020 15:32
@besser82
Copy link
Contributor Author

Coverage is fixed again: https://coveralls.io/repos/294348/builds

@besser82
Fix coveralls submission.
0dac15c 
coveralls-cpp is dead and does not work anymore.
Fortunately there is coveralls-lcov available.
@besser82
Copy link
Contributor Author

@hawicz This is ready to be merged.

@dota17 dota17 merged commit 69ceb38 into json-c:master Apr 11, 2020
@besser82 besser82 deleted the topic/besser82/coverage branch April 11, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@besser82 @coveralls @hawicz @dota17